Can you find this Delphi coding error (part 2)?

Can you spot the error in the following Delphi code? It is a function that returns a value.

function GetAmount(Value : Integer) : Integer;
  ModBalance, ExtraYield : Integer;
  Result := GetInitialValue(Value);

  if Result = 0 then;
    for I := 1 to 12 do
      Inc(Result, GetMonthly(I);

    Inc(Result, ExtraAmount(I));

OK, not too hard, was it?

Solution: The if-condition is short-circuited because of the trailing ";" after "then". The code in the following block will always be called. The resulting value from the function will just be wrong.

Not so hard to spot! But imagine finding this problem among thousands of lines of code spread over hundreds of units! And consider also a code base that is evolving all the time, so the code must constantly be rechecked.

The good news is that with Pascal Analyzer, our popular static code analyzer, you can automatically find these and many other kinds of coding issues. This particular error above is detected by the Warnings Report, in a section WARN30 "Short-circuited if-statements".

Pascal Analyzer has a total of 53 reports. Those are divided into roughly 200 sections, all providing statistics, references, errors and warnings for your code. Pascal Analyzer can be run as a standalone Windows application, or as a command-line program. The second choice is suitable if you want to integrate static code analysis with your build process.

Or use Pascal Expert, our RAD Studio plugin, to find the problems immediately while coding. Pascal Expert contains much of the same capabilities like Pascal Analyzer, and is obtainable with a discount when buying both products.

See our orders page for more details or get free evaluations from the download page.