Can you find this Delphi coding error (part 10)?

Can you spot the error in the following Delphi code extract?

..

function GetPeriodRevenue(Period : TPeriod) : Integer;
var
  DomesticSales, ForeignSales, ExtraOrdinary : Integer;
begin
  DomesticSales := GetDomesticSales(Period);
  ForeignSales := GetForeignSales(Period);
  ExtraOrdinary := GetExtraOrdinary(Period);
  
  Result := DomesticSales+ForeignSales;
end;

..

This was quite easy, right?

Solution: The local variable ExtraOrdinary is set, but then never referenced. This may indicate an error. Probably ExtraOrdinary should be included in calculation of the result for the function.

The good news is that with Pascal Analyzer, our popular static code analyzer product, these situations can be detected automatically. There is a section WARN5 in the Warnings Report. It is called "Variables that are set but never referenced".

Not so hard to spot! But imagine finding this problem among thousands of lines of code spread over hundreds of units! And consider also a code base that is evolving all the time, so the code must constantly be rechecked.

Pascal Analyzer has a total of 53 reports. Those are divided into over 230 sections, all providing statistics, references, errors and warnings for your code. Pascal Analyzer can be run as a standalone Windows application, or as a command-line program. The second choice is suitable if you want to integrate static code analysis with your build process.

Or use Pascal Expert, our RAD Studio plugin, to find the problems immediately while coding. Pascal Expert contains much of the same capabilities like Pascal Analyzer, and is obtainable with a discount when buying both products.

See our orders page for more details or get free evaluations from the download page.

Can you see the Delphi coding error? (Part 9)
Can you see the Delphi coding problem? (Part 8)
Can you see the Delphi coding error? (Part 7)
Can you see the Delphi coding error? (Part 6)
Can you see the Delphi coding error? (Part 5)
Can you see the Delphi coding error? (Part 4)
Can you see the Delphi coding error? (Part 3)
Can you see the Delphi coding error? (Part 2)
Can you see the Delphi coding error? (Part 1)